Skip to content

Shrink clusterd #301

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Shrink clusterd #301

merged 3 commits into from
Jan 20, 2023

Conversation

donald
Copy link
Collaborator

@donald donald commented Jan 20, 2023

clusterd: Remove daemon features

We now run clusterd as a systemd service. The features to daemonize,
redirect logging, restart and kill previous daemons are all not needed.
Additionally, the restart is buggy, because
Donald::Tools::kill_previous_server doesn't kill the parent - assuming
this is an rc.d script. However, in --foregound mode, the previous
daemon is in fact the parent.

  • Remove unused features and leave job control and logging to systemd.
  • Log into journal instead of into syslog.
  • Remove "Description=" from the unit, because its easier to identify
    things, when the name used in messages is the same as the unit name
    and the unit file name.

We are going to remove the --syslog option to log everything into
syslog. However, netlog messages received from netlog services should
still go into syslog. So use syslog() for that explicitly.
We now run clusterd as a systemd service. The features to daemonize,
redirect logging, restart and kill previous daemons are all not needed.
Additionally, the restart is buggy, because
Donald::Tools::kill_previous_server doesn't kill the parent - assuming
this is an rc.d script. However, in `--foregound` mode, the previous
daemon is in fact the parent.

- Remove unused features and leave job control and logging to systemd.
- Log into journal instead of into syslog.
- Remove "Description=" from the unit, because its easier to identify
  things, when the name used in messages is the same as the unit name
  and the unit file name.
@donald donald merged commit e78fb60 into master Jan 20, 2023
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants